Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved mecanum wheel model #9

Open
wants to merge 5 commits into
base: melodic-devel
Choose a base branch
from
Open

Improved mecanum wheel model #9

wants to merge 5 commits into from

Conversation

VladimirIvan
Copy link

@VladimirIvan VladimirIvan commented Jul 8, 2020 •
edited
Loading

  • Changed to use a passive rolling ball as a model instead of modifying the friction
  • Removed the following parameters: fixedLinkName, rollerAngle, rollerFriction, rollerSkidFriction
  • Added axis parameter
  • Removed dependency on ODE
  • Updated for compatibility with Gazebo 9
  • Added readme
  • Updated changelog
  • Did not change version number
  • Only supported for ODE and Dart

@civerachb-cpr
Copy link
Contributor

If you're still working on this PR can you please mark it as WIP?
If it's ready to be reviewed, can you please rebase and address the merge conflicts above; it should not be necessary to manually edit the Changelog; that file gets automatically updated when we release the package.

@VladimirIvan
Copy link
Author

Hi @civerachb-cpr,
it looked like the repo is not supported any more so I the PR slipped my radar. It is now rebased and finished. Please go ahead with the code review.

civerachb-cpr
civerachb-cpr requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@civerachb-cpr civerachb-cpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change to the package maintainer.
Everything else looks generally OK, but I'll need to run some tests before I can approve the PR.

mecanum_gazebo_plugin/package.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@civerachb-cpr civerachb-cpr civerachb-cpr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladimirIvan @civerachb-cpr